[GitHub] flink pull request #3514: [FLINK-6007] Allow key removal from within the wat...

2017-03-13 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/3514 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3514: [FLINK-6007] Allow key removal from within the wat...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3514#discussion_r105649773 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalWatermarkCallbackService.java --- @@ -58,7 +59,17 @@ *

[GitHub] flink pull request #3514: [FLINK-6007] Allow key removal from within the wat...

2017-03-13 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3514#discussion_r105648422 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalWatermarkCallbackService.java --- @@ -58,7 +59,17 @@

[GitHub] flink pull request #3514: [FLINK-6007] Allow key removal from within the wat...

2017-03-10 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3514 [FLINK-6007] Allow key removal from within the watermark callback. When deleting a key from the InternalWatermarkCallbackService, the deleted key is put into a separate set, and the actual deletion