[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107674217 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java --- @@ -121,6 +121,19 @@

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107674329 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -352,6 +352,19 @@ public void

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107506662 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java --- @@ -122,6 +121,19 @@

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107475345 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java --- @@ -0,0

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107474350 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java --- @@ -0,0

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107473789 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java --- @@ -0,0

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107471533 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java --- @@ -0,0

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107450020 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -138,7 +138,7 @@ *

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107450009 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java --- @@ -0,0

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107446618 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -574,7 +588,7 @@ private

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107446308 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -138,7 +138,7 @@ *

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107446384 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -352,6 +352,20 @@ public

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107445987 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java --- @@ -122,6 +121,20 @@

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107445929 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java --- @@ -122,6 +121,20 @@

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/3587 [FLINK-5972] Don't allow shrinking merging windows Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your