Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126940120
--- Diff:
flink-metrics/flink-metrics-statsd/src/test/java/org/apache/flink/metrics/statsd/StatsDReporterTest.java
---
@@ -60,6 +60,20 @@
public class
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126930326
--- Diff: docs/monitoring/metrics.md ---
@@ -376,6 +376,7 @@ Parameters:
- `dmax` - hard limit for how long an old metric should be retained
-
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126915402
--- Diff:
flink-metrics/flink-metrics-statsd/src/test/java/org/apache/flink/metrics/statsd/StatsDReporterTest.java
---
@@ -60,6 +60,20 @@
public class
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126918307
--- Diff: docs/monitoring/metrics.md ---
@@ -376,6 +376,7 @@ Parameters:
- `dmax` - hard limit for how long an old metric should be retained
- `ttl`
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126443494
--- Diff:
flink-metrics/flink-metrics-statsd/src/main/java/org/apache/flink/metrics/statsd/StatsDReporter.java
---
@@ -193,7 +198,10 @@ private void
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126446702
--- Diff: docs/monitoring/metrics.md ---
@@ -376,6 +376,7 @@ Parameters:
- `dmax` - hard limit for how long an old metric should be retained
-
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126442516
--- Diff:
flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java
---
@@ -184,7 +188,10 @@ public
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126443486
--- Diff:
flink-metrics/flink-metrics-statsd/src/test/java/org/apache/flink/metrics/statsd/StatsDReporterTest.java
---
@@ -60,6 +60,20 @@
public class
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4110
[FLINK-6900] [metrics] Limit size of metric name components
This PR modifies the `ScheduledDropwizardReporter` to limit the size of
every metric name component to 80 characters, with the same
