[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-22 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r123439484 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java --- @@ -36,24 +34,14 @@ private final

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-22 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r123439602 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java --- @@ -98,32 +82,9 @@ public int hashCode() {

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-21 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r123204588 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -126,6 +129,7 @@ public

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-21 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r123192355 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -126,6 +129,7 @@ public

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-21 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r123186831 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -1131,6 +1152,7 @@ private void serializeStates(Set

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-21 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r123184832 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -1131,6 +1152,7 @@ private void serializeStates(Set

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-20 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r123140396 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java --- @@ -36,6 +36,12 @@ private final

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-20 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r123139456 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -126,6 +129,7 @@ public

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-20 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r123138630 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -1131,6 +1152,7 @@ private void serializeStates(Set

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-20 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r122978426 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -1164,16 +1186,16 @@ private void serializeStates(Set

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-20 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r122982179 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java --- @@ -36,6 +36,12 @@ private final

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-20 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r122985049 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -126,6 +129,7 @@ public

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-20 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r122974349 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ConditionRegistry.java --- @@ -0,0 +1,135 @@ +/* + * Licensed to the

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-20 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r122982790 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java --- @@ -68,6 +72,15 @@ public StateTransitionAction

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-20 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r122978388 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -1131,6 +1152,7 @@ private void serializeStates(Set

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-20 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r122929120 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ConditionRegistry.java --- @@ -0,0 +1,135 @@ +/* + * Licensed to the

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-20 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r122918782 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ConditionRegistry.java --- @@ -0,0 +1,135 @@ +/* + * Licensed to the

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-20 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/4145 [FLINK-6938][FLINK-6939] [cep] Not store IterativeCondition with NFA state and support RichFunction interface The core idea is that the `StateTransition` is unique in a NFA graph. So we store the