Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r130345351
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java ---
@@ -23,9 +23,32 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r130338928
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java ---
@@ -23,9 +23,32 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r130338481
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/FromElementsTest.java ---
@@ -22,7 +22,7 @@
import org.junit.Test;
/**
-
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r127580379
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java ---
@@ -23,9 +23,32 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r127506234
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java
---
@@ -266,42 +269,41 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r127504115
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -21,13 +21,18 @@
import org.apache.flink.annotation.Internal;
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r127505784
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/TextOutputFormat.java ---
@@ -18,65 +18,73 @@
package
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r127506011
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/CollectionInputFormatTest.java
---
@@ -90,18 +94,18 @@ public String toString() {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r127506443
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/FromElementsTest.java ---
@@ -18,8 +18,12 @@
package org.apache.flink.api.java.io;
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r127505648
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/TextOutputFormat.java ---
@@ -18,65 +18,73 @@
package
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r127504421
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java ---
@@ -23,9 +23,32 @@
import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r127506187
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java
---
@@ -224,34 +230,31 @@ private void ignoreInvalidLines(int
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4340#discussion_r127504763
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/PrintingOutputFormat.java
---
@@ -18,12 +18,16 @@
package
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/4340
[FLINK-7185] Activate checkstyle flink-java/io
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your
15 matches
Mail list logo
