Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4532
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r133037759
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132971979
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132889590
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132889039
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -719,33 +715,47 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132863952
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/ProctimeSqlFunction.scala
---
@@ -22,12 +22,12 @@ import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132854814
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/OutputRowtimeProcessFunction.scala
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132854238
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132842811
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -719,33 +715,47 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132840719
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -719,33 +715,47 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132841043
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132834552
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132839934
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/conversion/CRowToJavaTupleMapRunner.scala
---
@@ -16,32 +16,32 @@
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132833668
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/OutputRowtimeProcessFunction.scala
---
@@ -0,0 +1,62 @@
+/*
+ *
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132822158
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132820853
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132819240
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132819174
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4532#discussion_r132817252
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -667,30 +719,62 @@ abstract class
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/4532
[FLINK-7337] [table] Refactor internal handling of time indicator
attributes and efficiency
## What is the purpose of the change
*This PR is an improvement of @fhueske's PR #4488. For an
20 matches
Mail list logo
