[GitHub] flink pull request #4561: [FLINK-7476][streaming] Continue using previous tr...

2017-08-24 Thread pnowojski
Github user pnowojski closed the pull request at: https://github.com/apache/flink/pull/4561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] flink pull request #4561: [FLINK-7476][streaming] Continue using previous tr...

2017-08-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4561#discussion_r134771937 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -185,11 +253,44 @@ pr

[GitHub] flink pull request #4561: [FLINK-7476][streaming] Continue using previous tr...

2017-08-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4561#discussion_r134759790 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -185,11 +253,44 @@ p

[GitHub] flink pull request #4561: [FLINK-7476][streaming] Continue using previous tr...

2017-08-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4561#discussion_r134737971 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -185,11 +253,44 @@ pr

[GitHub] flink pull request #4561: [FLINK-7476][streaming] Continue using previous tr...

2017-08-18 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/4561 [FLINK-7476][streaming] Continue using previous transaction on failures First commit comes from #4557. Previously when using TwoPhaseCommitSinkFunction, if there was some intermittent fa