Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4813
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146605323
--- Diff: docs/dev/table/tableApi.md ---
@@ -985,19 +985,22 @@ Table result = in.orderBy("a.asc");
-Limit
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146542343
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -745,12 +748,65 @@ class Table(
*
*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146540313
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -745,12 +748,65 @@ class Table(
*
*
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146489748
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -726,7 +726,10 @@ class Table(
* }}}
*
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146490693
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -745,12 +748,65 @@ class Table(
*
*
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146490303
--- Diff: docs/dev/table/tableApi.md ---
@@ -985,19 +985,22 @@ Table result = in.orderBy("a.asc");
-Limit
+
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146426403
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -745,12 +748,65 @@ class Table(
*
*
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146423134
--- Diff: docs/dev/table/tableApi.md ---
@@ -1031,19 +1034,22 @@ val result = in.orderBy('a.asc);
-Limit
+
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146423039
--- Diff: docs/dev/table/tableApi.md ---
@@ -985,19 +985,22 @@ Table result = in.orderBy("a.asc");
-Limit
+
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146423953
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -745,12 +748,65 @@ class Table(
*
*
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146424180
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -745,12 +748,65 @@ class Table(
*
*
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r146423916
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -745,12 +748,65 @@ class Table(
*
*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r144268057
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/validation/SortValidationTest.scala
---
@@ -27,10 +27,26 @@
Github user hustfxj commented on a diff in the pull request:
https://github.com/apache/flink/pull/4813#discussion_r144257631
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/validation/SortValidationTest.scala
---
@@ -27,10 +27,26 @@
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/4813
[FLINK-7821] [table] Deprecate Table.limit() and replace it by
Table.offset() and Table.fetch().
## What is the purpose of the change
- `Table.limit(n)` has unexpected semantics of
16 matches
Mail list logo
