[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5040 ---

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-30 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r154181460 --- Diff: docs/dev/table/tableApi.md --- @@ -2993,6 +2993,30 @@ MAP.at(ANY) + + + + Row functions +

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-30 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r154179674 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/utils/RowTypeTestBase.scala --- @@ -0,0 +1,64 @@ +/* + *

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r153801798 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -959,6 +959,19 @@ object array { }

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r153802956 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1308,6 +1313,19 @@ abstract class

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r153803084 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1556,6 +1574,21 @@ abstract class

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r153801541 --- Diff: docs/dev/table/tableApi.md --- @@ -2993,6 +2993,30 @@ MAP.at(ANY) + + + + Row functions +

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r153803851 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -849,6 +850,36 @@ object

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r153801369 --- Diff: docs/dev/table/tableApi.md --- @@ -2993,6 +2993,30 @@ MAP.at(ANY) + + + + Row functions +

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r153807597 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/CalcITCase.scala --- @@ -308,6 +308,27 @@ class CalcITCase(

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r153803232 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1556,6 +1574,21 @@ abstract class

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r153802731 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1308,6 +1313,19 @@ abstract class

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r153800721 --- Diff: docs/dev/table/sql.md --- @@ -2355,6 +2355,41 @@ map ‘[’ key ‘]’ + --- End diff -- I would put this

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r153806967 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/utils/RowTypeTestBase.scala --- @@ -0,0 +1,64 @@ +/* + *

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-22 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r152588446 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -835,6 +836,43 @@ object

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-22 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r152614003 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala --- @@ -417,6 +417,10 @@ object FlinkTypeFactory

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-22 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5040#discussion_r152588168 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -835,6 +836,43 @@ object

[GitHub] flink pull request #5040: [FLINK-8104][Table API] fixing ROW type value cons...

2017-11-20 Thread walterddr
GitHub user walterddr opened a pull request: https://github.com/apache/flink/pull/5040 [FLINK-8104][Table API] fixing ROW type value constructor for SQL API. ## What is the purpose of the change Supports creation of a ROW based on fields or literals. such as: