[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-27 Thread ChrisChinchilla
Github user ChrisChinchilla commented on a diff in the pull request: https://github.com/apache/flink/pull/5045#discussion_r153374829 --- Diff: docs/concepts/runtime.md --- @@ -74,10 +74,10 @@ To control how many tasks a worker accepts, a worker has so called **task slots*

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-27 Thread ChrisChinchilla
Github user ChrisChinchilla commented on a diff in the pull request: https://github.com/apache/flink/pull/5045#discussion_r153374312 --- Diff: docs/concepts/programming-model.md --- @@ -33,53 +33,52 @@ Flink offers different levels of abstraction to develop streaming/batch

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-22 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5045#discussion_r152608576 --- Diff: docs/concepts/programming-model.md --- @@ -33,53 +33,52 @@ Flink offers different levels of abstraction to develop streaming/batch applicat

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-22 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5045#discussion_r152608405 --- Diff: docs/concepts/programming-model.md --- @@ -132,14 +131,13 @@ One typically distinguishes different types of windows, such as *tumbling window

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-22 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5045#discussion_r152607252 --- Diff: docs/concepts/programming-model.md --- @@ -33,53 +33,52 @@ Flink offers different levels of abstraction to develop streaming/batch applicat

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-22 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5045#discussion_r152612059 --- Diff: docs/concepts/runtime.md --- @@ -107,21 +107,20 @@ With hyper-threading, each slot then takes 2 or more hardware thread contexts. ##

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-22 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5045#discussion_r152605878 --- Diff: docs/concepts/programming-model.md --- @@ -33,53 +33,52 @@ Flink offers different levels of abstraction to develop streaming/batch applicat

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-22 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5045#discussion_r152609451 --- Diff: docs/concepts/runtime.md --- @@ -74,10 +74,10 @@ To control how many tasks a worker accepts, a worker has so called **task slots* Each

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5045#discussion_r152527676 --- Diff: docs/concepts/programming-model.md --- @@ -33,53 +33,52 @@ Flink offers different levels of abstraction to develop streaming/batch applicat

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5045#discussion_r152528590 --- Diff: docs/concepts/runtime.md --- @@ -28,10 +28,10 @@ under the License. ## Tasks and Operator Chains -For distributed execution,

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-21 Thread ChrisChinchilla
GitHub user ChrisChinchilla opened a pull request: https://github.com/apache/flink/pull/5045 [hotfix][docs] Review of concepts docs for grammar and clarity Spending some time doing a brief review of a few docs sections, just a start and I think more could be done. I didn't