[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r163161066 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/standalone/StandaloneHaServices.java --- @@ -132,4 +137,23 @@ public Leade

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r163161003 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -327,13 +376,14 @@ public T getClusterId() { }

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r163160938 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusResponse getCl

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r163160802 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusResponse getCl

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r163160900 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -61,46 +69,77 @@ import org.apache.flink.runtime.

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r163160849 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -327,13 +376,14 @@ public T getClusterId() { }

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r163160791 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusResponse getCl

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r163160703 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClientConfiguration.java --- @@ -30,49 +28,20 @@ */ public fina

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r163160672 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java --- @@ -144,6 +154,15 @@ public WebMonitorEndpoint(

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162893190 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/LeaderHolder.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Softwar

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-21 Thread satybald
Github user satybald commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162814676 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/LeaderHolder.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache So

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162715070 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusResponse getCl

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162714906 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -61,46 +69,77 @@ import org.apache.flink.runtime.

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162714628 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusResponse getCl

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162690747 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java --- @@ -144,6 +154,15 @@ public WebMonitorEndpoint(

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162695596 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusRespo

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162693549 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -327,13 +376,14 @@ public T getClusterId() {

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162696312 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusRespo

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162687082 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClientConfiguration.java --- @@ -30,49 +28,20 @@ */ pu

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162699368 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusRespo

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162694907 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusRespo

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162699002 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusRespo

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162696516 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -61,46 +69,77 @@ import org.apache.flink

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162696429 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusRespo

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162687806 --- Diff: flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java --- @@ -285,13 +289,45 @@ private static String createMessageHtml

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162689030 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -251,6 +245,12 @@ protected void channelRead0(ChannelHandlerC

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162692567 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -61,46 +69,77 @@ import org.apache.flink

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162581631 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -376,4 +430,99 @@ public GetClusterStatusResponse getCl

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-18 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162416324 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -327,13 +376,14 @@ public T getClusterId() { }

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-18 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162414419 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionService.java --- @@ -412,4 +413,11 @@ protected void handle

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-18 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162412277 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -596,11 +596,11 @@ public int run(String[] args) throws CliArgsExce

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-18 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162413303 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -251,6 +245,12 @@ protected void channelRead0(ChannelHandlerContext ct

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-18 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5312#discussion_r162412749 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/standalone/StandaloneHaServices.java --- @@ -132,4 +137,23 @@ public Leade

[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

2018-01-18 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5312 [FLINK-8344][WIP] Add support for HA to RestClusterClient WIP You can merge this pull request into a Git repository by running: $ git pull https://github.com/GJL/flink rest-cluster-client-ha Alter