Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6059
---
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6059#discussion_r194482707
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -296,42 +292,31 @@ public void resetNFAChanged() {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6059#discussion_r194473454
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -296,42 +292,31 @@ public void resetNFAChanged() {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6059#discussion_r194470370
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -296,42 +292,31 @@ public void resetNFAChanged() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6059#discussion_r194469640
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -296,42 +292,31 @@ public void resetNFAChanged() {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6059#discussion_r194468194
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -296,42 +292,31 @@ public void resetNFAChanged() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6059#discussion_r192651450
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/EventWrapper.java
---
@@ -0,0 +1,188 @@
+/*
+ * Licensed
Github user Aitozi commented on a diff in the pull request:
https://github.com/apache/flink/pull/6059#discussion_r192558813
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/EventWrapper.java
---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/6059
[Flink-9418] Migrate SharedBuffer to use MapState
## What is the purpose of the change
Migrate `SharedBuffer` to `MapState` so to improve memory managment and
decrease the amount of data