[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-07-03 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r199783102 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -1029,6 +1029,29 @@ object

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-07-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r199485393 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -1029,6 +1029,29 @@ object

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-07-01 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r199352237 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -1029,6 +1029,29 @@ object

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-07-01 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r199349619 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -1029,6 +1029,29 @@ object

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r199190279 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -1029,6 +1029,29 @@ object

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-28 Thread xueyumusic
Github user xueyumusic commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r199040249 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -1029,6 +1029,29 @@ object

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-24 Thread xueyumusic
Github user xueyumusic commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197674277 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -349,6 +349,17 @@ case class TimestampAdd(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-24 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197662959 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -349,6 +349,17 @@ case class TimestampAdd(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-24 Thread xueyumusic
Github user xueyumusic commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197642129 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,71 @@ case class TemporalOverlaps(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-24 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197640442 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,71 @@ case class TemporalOverlaps(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-24 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197640444 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,71 @@ case class TemporalOverlaps(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197622239 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread xueyumusic
Github user xueyumusic commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197616443 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197614200 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197614217 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197614206 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197614210 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197614223 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197613995 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197613915 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps(

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197613157 --- Diff: docs/dev/table/tableApi.md --- @@ -2804,6 +2804,17 @@ dateFormat(TIMESTAMP, STRING) + + +

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-23 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197614566 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps(