[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199860548 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/BatchTableEnvironment.scala --- @@ -94,11 +95,12 @@ class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199860444 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/BatchTableEnvironment.scala --- @@ -53,12 +53,13 @@ class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199860789 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/batch/sql/JavaSqlITCase.java --- @@ -71,8 +71,10 @@ public void

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199858297 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala --- @@ -77,15 +90,38 @@ class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199857602 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -415,6 +416,19 @@ abstract class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199857801 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -433,9 +447,24 @@ abstract class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199860711 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/batch/sql/JavaSqlITCase.java --- @@ -71,8 +71,10 @@ public void

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199859899 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala --- @@ -77,15 +90,38 @@ class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199855960 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -95,15 +95,17 @@ abstract class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199860344 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala --- @@ -118,15 +195,19 @@ class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199860044 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala --- @@ -95,12 +131,53 @@ class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199858196 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala --- @@ -55,9 +55,22 @@ class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199857340 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -280,16 +284,19 @@ abstract class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199857390 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -163,12 +164,14 @@ abstract class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199860145 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala --- @@ -95,12 +131,53 @@ class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199857354 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -300,9 +307,10 @@ abstract class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199857432 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -415,6 +416,19 @@ abstract class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-03 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6236#discussion_r199857321 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -145,12 +147,14 @@ abstract class

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-02 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/flink/pull/6236 [FLINK-9699]. Add api to replace registered table *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your