[GitHub] flink pull request #6255: [FLINK-9681] [table] Make sure difference between ...

2018-07-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6255 ---

[GitHub] flink pull request #6255: [FLINK-9681] [table] Make sure difference between ...

2018-07-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6255#discussion_r200333630 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/HarnessTestBase.scala --- @@ -384,4 +386,12 @@ object

[GitHub] flink pull request #6255: [FLINK-9681] [table] Make sure difference between ...

2018-07-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6255#discussion_r200330683 --- Diff: docs/dev/table/streaming.md --- @@ -591,16 +589,14 @@ qConfig.withIdleStateRetentionTime(Time.hours(12); val qConfig: StreamQueryConfig

[GitHub] flink pull request #6255: [FLINK-9681] [table] Make sure difference between ...

2018-07-04 Thread hequn8128
GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/6255 [FLINK-9681] [table] Make sure difference between minRetentionTime and maxRetentionTime at least 5 minutes ## What is the purpose of the change This PR aims to make sure difference