[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6363 ---

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203662639 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java --- @@ -0,0 +1,103 @@ +/* + * License

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203432013 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java --- @@ -0,0 +1,84 @@ +/* + * Licensed

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203414529 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java --- @@ -220,4 +224,5 @@ public void testUploadCleanupOnFailure

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203422176 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java --- @@ -0,0 +1,84 @@ +/* + * Licensed

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203414700 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java --- @@ -0,0 +1,84 @@ +/* + * Licensed

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203398509 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java --- @@ -50,6 +55,24 @@ private static final Objec

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203373280 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java --- @@ -50,6 +55,24 @@ private static final Obje

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/6363 [FLINK-9860][REST] fix buffer leak in FileUploadHandler ## What is the purpose of the change The current implementation of `FileUploadHandler` has two cases where the given message was not re