[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720999 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -297,7 +300,13 @@ public void

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721547 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSourceTaskTest.java --- @@ -45,33 +46,30 @@ public class

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721015 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -337,7 +345,13 @@ public void

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721035 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -363,7 +376,9 @@ public void testCancelDataSinkTask()

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720914 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -79,12 +75,11 @@ public void testDataSinkTask() {

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721046 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -419,7 +432,13 @@ public void

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721390 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSourceTaskTest.java --- @@ -45,33 +46,30 @@ public class

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720983 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -225,7 +224,13 @@ public void

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204718919 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java --- @@

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204722139 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/EnumerateNestedFilesTest.java --- @@ -240,36 +205,19 @@ public void

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204719730 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorITCase.java --- @@ -127,7 +132,7 @@ public void testSlotAllocation()

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720974 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -141,7 +136,13 @@ public void testUnionDataSinkTask()

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204719565 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java --- @@ -218,7 +224,7 @@ public void TestAnonymousClass() throws

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720758 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -49,22 +50,17 @@ import static

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720065 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/EnumerateNestedFilesTest.java --- @@ -338,22 +279,11 @@ public void

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-23 Thread maheshsenni
GitHub user maheshsenni opened a pull request: https://github.com/apache/flink/pull/6399 [FLINK-5860] [tests] Replace java.io.tmpdir with JUnit TemporaryFolder in tests ## What is the purpose of the change JUnit's TemporaryFolder is a better way to handle temporary folders