sunjincheng121 commented on issue #7167: [FLINK-10973] [table] Add support for
map to table API
URL: https://github.com/apache/flink/pull/7167#issuecomment-445072642
Here a minor suggestion： In the java example we use `RowTypeInfo.java`
instead of `Types.scala` to create getResultType.
sunjincheng121 commented on issue #7167: [FLINK-10973] [table] Add support for
map to table API
URL: https://github.com/apache/flink/pull/7167#issuecomment-443904942
Hi @twalthr,
Are there some comments about this PR? I appreciate if you can give some
feedback :)
Bests,
Jincheng
sunjincheng121 commented on issue #7167: [FLINK-10973] [table] Add support for
map to table API
URL: https://github.com/apache/flink/pull/7167#issuecomment-442840488
@twalthr Sounds good!
I I totally agree that we have to take this change very carefully. :)
Thanks,
Jincheng
sunjincheng121 commented on issue #7167: [FLINK-10973] [table] Add support for
map to table API
URL: https://github.com/apache/flink/pull/7167#issuecomment-442352308
@dianfu Thanks for the quick update !
LGTM ! +1
Wait a minute to see if there are other committer that will leave
sunjincheng121 commented on issue #7167: [FLINK-10973] [table] Add support for
map to table API
URL: https://github.com/apache/flink/pull/7167#issuecomment-442279595
@wuchong, Yes, we are plan to bring up a discuss in mail list about Column
operation, such as short cut: `*`, `_`
