[GitHub] twalthr commented on issue #6585: [FLINK-10172][table]re-adding asc & desc suffix expression to expressionParser

2018-08-23 Thread GitBox
twalthr commented on issue #6585: [FLINK-10172][table]re-adding asc & desc suffix expression to expressionParser URL: https://github.com/apache/flink/pull/6585#issuecomment-415329206 Thank you @walterddr. I would open an issue for this minor thing to at least track it.

[GitHub] twalthr commented on issue #6585: [FLINK-10172][table]re-adding asc & desc suffix expression to expressionParser

2018-08-22 Thread GitBox
twalthr commented on issue #6585: [FLINK-10172][table]re-adding asc & desc suffix expression to expressionParser URL: https://github.com/apache/flink/pull/6585#issuecomment-415064636 Thanks for the explanation @fhueske and @walterddr. Feel free to add more tests if they make sense. But

[GitHub] twalthr commented on issue #6585: [FLINK-10172][table]re-adding asc & desc suffix expression to expressionParser

2018-08-22 Thread GitBox
twalthr commented on issue #6585: [FLINK-10172][table]re-adding asc & desc suffix expression to expressionParser URL: https://github.com/apache/flink/pull/6585#issuecomment-414922702 @walterddr This PR fixes the issue but the question is why did the parser not resolve the `asc`/`desc`