[GitHub] xccui commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL

2018-09-26 Thread GitBox
xccui commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6576#issuecomment-424709936 Thanks for the update @Guibo-Pan. I'll have a final check and merge this. Best, Xingcan

[GitHub] xccui commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL

2018-09-20 Thread GitBox
xccui commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6576#issuecomment-423406252 Hi @Guibo-Pan, I wonder if you could rebase your code to resolve these conflicts. Thanks, Xingcan

[GitHub] xccui commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL

2018-08-21 Thread GitBox
xccui commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6576#issuecomment-414571176 Hi @Guibo-Pan, see https://github.com/xccui/flink/commit/e374c3ef9dccb2dc4fa13e939834e9506cfcd695 for an example. Besides,

[GitHub] xccui commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL

2018-08-21 Thread GitBox
xccui commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6576#issuecomment-414559283 Hi @Guibo-Pan, in SQL convention, any null argument will lead to a null result. Thus when generating a scalar function call,