yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-429834979
Refactored commit message and rebased this PR.
This is an automated
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-429817604
In addition, I think we should modify the title of the JIRA issue and this
PR. What do you think?
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-429817077
@aljoscha The renaming work has been completed.
> As a follow-up, we should change/or add end-to-end tests that use the new
Kafka
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-429687222
> Can deserializer access ConsumerRecord to get headers and timestamp? Or it
will be PR on top this PR?
@alexeyt820 I agree with
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-429524696
@aljoscha I have refactored and separated the commits.
This is an
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-429376594
@aljoscha OK, I will refactor the commits and commit messages.
This is an
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-429367779
@aljoscha compile and test successfully, what I should do next?
This is an
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-429301742
> Could you please also mark the consumer and producer as `@PublicEvolving`?
> And we could probably add the Javadoc from
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-429266318
@aljoscha when I rename 'Kafka20TableSink' -> 'KafkaTableSink', but
'KafkaTableSink' exists in 'flink-connector-kafka-base'. Shall we
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-429259771
@aljoscha Yes, the test passed. I will change the module name later, but
there is a little doubt. If no version number is added, the user
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-428882816
yes, thanks for your solution @aljoscha . I will take a look about the
failed test case because of timeout.
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-428619000
@aljoscha still many failed test cases because of timeout and ClassNotFound.
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-428544751
@aljoscha yes, you are right, I have update the PR.
This is an automated
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-428518943
@aljoscha OK, I will try it soon.
This is an automated message from the
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-428502808
> @yanghua The internals code (and most of the code in general) you were
able to copy from the other connectors, correct? What did you have
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-428465111
@aljoscha some test cases which used kafka-server, failed with this
exception :
```
java.lang.NoClassDefFoundError:
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-428242063
@alexeyt820 thanks for paying attention to this PR. I am trying to fix some
test issue. Based on the community's efficiency, It may not
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-425935918
@pnowojski Ok, what I am currently doing is removing the cascading
dependencies in flink-connector-kafka-2.0. And verify the correctness of
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-423929496
OK, @aljoscha This PR currently mainly proves that most of the source code
of flink-connector-kafka-0.11 is compatible with kafka client
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-422778285
@pnowojski If we don't consider the failed test case, then this PR applies
to both Kafka client 1.0 and kafka client 2.0. Basically it also
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-422008333
I have already read the comment for this method, yes, it will cause the test
program to become unresponsive. But each PR will verify this
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-421998532
@pnowojski OK. There is a test case `testOneToOneAtLeastOnceRegularSink`
always can not been passed, I am trying to find the reason.
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-421693803
Currently this PR is not ready to be reviewed, it still needs some
refactoring.
23 matches
Mail list logo
