yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-438553957
I have created a new issue FLINK-10872 to provide end-to-end sql client test
for kafka connector 0.11. Once this PR
yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-438278306
I have reorganized commits to facilitate merging. This change has been
validated on my own Travis (misc is out of
yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-438237291
@pnowojski Can you quickly take a look at whether the latest changes meet
your requirements?
yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-438201782
@twalthr @pnowojski Thank you for your suggestion. It seems that I also
misunderstood the original meaning of
yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-437933478
@pnowojski I saw one step of this test case is `echo "Executing SQL: Match
recognize -> Elasticsearch"` which
yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-437928244
@pnowojski I agree with you. Indeed, we can separate it. And splitting seems
to be mostly targeted at shell
yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-437294266
@pnowojski Currently Travis is passed, I see that you have merged the fix
for elasticsearch, I will merge your fix
yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-436592354
@pnowojski OK, I will try to fix it.
This is an
yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-436192629
@pnowojski It is not up to date, it blocked by FLINK-10600(have merged) and
FLINK-10704. I will update it soon.
yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-435803131
This PR was blocked by FLINK-10600 and FLINK-10704. cc @pnowojski @twalthr
and @tillrohrmann
yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-433375753
@pnowojski I am currently running locally. From the JM log, I found that
multiple kafka and connector dependencies
yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-433329338
@pnowojski For end-to-end testing, do we need to test multiple connectors or
replace the old connector for testing?
yanghua commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end to
test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-433024342
Currently, this PR is not ready to be reviewed, it is blocked by
FLINK-10600, and it contains shell files that are
13 matches
Mail list logo