[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector

2018-11-19 Thread GitBox
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-440177013 @pnowojski How about providing a `flink-examples/flink-examples-e2e` module to place these end-to-end examples?

[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector

2018-11-19 Thread GitBox
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-439946559 I agree that it doesn't make much sense to add Kafka example to Flink binary. Examples released with Flink binary should

[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector

2018-11-19 Thread GitBox
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-439877741 I think @tillrohrmann means that we don't want the e2e test to rely on `flink-dist`. This way we can run

[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector

2018-11-18 Thread GitBox
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-439790249 @tillrohrmann I agree with your opinion. I have created a new issue (FLINK-10922) to rework specific modules (0.10, 0.11

[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector

2018-11-07 Thread GitBox
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-436593846 Yes, I also encountered this problem. The first time I forgot to add the Apache License to the pom file, but when I added

[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector

2018-11-07 Thread GitBox
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-436561044 @pnowojski @aljoscha can you review this PR? thanks. This