zentol opened a new pull request #7251: [FLINK-11026][ES6] Rework creation of fat sql-client jars URL: https://github.com/apache/flink/pull/7251 Based on #7247. ## What is the purpose of the change This PR is a PoC for reworking the packaging of jars specific to the sql-client (which basically are just fat-jars). Only the `flink-connector-elasticsearch6` module is covered here; if accepted the same principle should be applied to the kafka connectors (0.10, 0.11, 2) and all formats. Instead of defining separate shade-plugin execution with a custom artifactSuffix this PR adds a dedicated `flink-sql-connector-elasticsearch6` module which only contains the packaging logic. This is a similar approach that we've already been using for `flink-shaded-hadoop2-uber`. The main motivation for this is licensing; for accurate notice files it is necessary to be able to supply each artifact with distinct NOTICE files. This cannot be done within a single module in a reasonable way. We would have to un-package each created jar, add the appropriate license files, and re-pack them again. We'd end up with tightly-coupled plugin definitions (since the names have to match!) and an overall more complicated (and slower!) build. ## Brief change log * add new `flink-sql-connector-elasticsearch6` module containing the sql-client-specific shade-plugin configuration and apply the following modifications * set `executionId` to `shade-flink` * disable `shadedArtifactAttached` so only a single jar is deployed * remove sql-jar suffix as it is no longer necessary * remove sqlJars profile from `flink-connector-elasticsearch6` * add `sqlJars` profile to `flink-connectors` to support skipping the creation of sql jars ## Verifying this change Covered by sql-client E2E test. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes) ## Documentation I have not checked the documentation yet for references that would have to be changed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
