dawidwys merged PR #23411:
URL: https://github.com/apache/flink/pull/23411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dawidwys commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1930284532
Thanks for the update @Jiabao-Sun The implementation looks good now. I want
to go through the tests again, but I need a bit more time. I hope this is fine,
cause anyway we need to wait
dawidwys commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1477969162
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
snuyanzin commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1924052949
I think we could wait until Monday or even more since right now a feature
freeze and need to wait for cutting release branch
--
This is an automated message from the Apache Git
dawidwys commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1924010094
Sorry, it takes such a long time from my side. I had a vacation in the
meantime. I'll try to check it Monday. Nevertheless if you're comfortable with
the PR @snuyanzin feel free to
Jiabao-Sun commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1903588731
Hi @dawidwys, please help review it again when you have time.
Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Jiabao-Sun commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1898595368
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1457306043
##
docs/data/sql_functions.yml:
##
@@ -1059,6 +1059,13 @@ aggregate:
Divides the rows for each window partition into `n` buckets ranging from
1 to at most
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1457306043
##
docs/data/sql_functions.yml:
##
@@ -1059,6 +1059,13 @@ aggregate:
Divides the rows for each window partition into `n` buckets ranging from
1 to at most
Jiabao-Sun commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1897966163
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Jiabao-Sun commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1897661962
> Thanks for addressing comments in general it looks ok from my side i guess
there is one little thing: since it is based on Calcite parser it allows to
have `ORDER BY` inside... At
snuyanzin commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1897393850
Thanks for addressing comments
in general it looks ok from my side
i guess there is one little thing: since it is based on Calcite parser it
allows to have `ORDER BY` inside...
Jiabao-Sun commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1455187450
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
Jiabao-Sun commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1455190307
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
Jiabao-Sun commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1455187450
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1453313913
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1453313913
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1453313913
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1453283389
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
dawidwys commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1453268979
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
dawidwys commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1453268979
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
dawidwys commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1453268979
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
Jiabao-Sun commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1453252729
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
Jiabao-Sun commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1453223169
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1452991614
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1452991614
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1452991614
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1452991614
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
Jiabao-Sun commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1893141857
Thanks @snuyanzin @dawidwys for the review.
Could you help review it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Jiabao-Sun commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1452975551
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
Jiabao-Sun commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1452891261
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/bridging/BridgingSqlAggFunction.java:
##
@@ -63,6 +64,7 @@ public final
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1452799002
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1452798689
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
snuyanzin commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1452798388
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the
snuyanzin commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1892868178
thanks a lot for the explanation @dawidwys you're right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dawidwys commented on code in PR #23411:
URL: https://github.com/apache/flink/pull/23411#discussion_r1452526246
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/bridging/BridgingSqlAggFunction.java:
##
@@ -63,6 +64,7 @@ public final
dawidwys commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1892398690
https://github.com/apache/flink/pull/23411#pullrequestreview-1770150649
It took me a while to understand that myself, but I think it's actually ok
to depend on the
Jiabao-Sun commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1862451170
Hi @snuyanzin, could you help take a look again when you have time?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Jiabao-Sun commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1859780440
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
snuyanzin commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1845527082
yes, sorry was not clear enough
>to compare when merging and retracting lists?
yes
--
This is an automated message from the Apache Git Service.
To respond to the message,
Jiabao-Sun commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1845473679
Do you mean using equalityEvaluator to compare when merging and retracting
lists?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Jiabao-Sun commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1845388338
Thanks @snuyanzin for the review.
Sorry, I was a little puzzled because I did not use `HashMap` in
`Arrayaggfunction`.
Could you help pinpoint exactly where it is?
--
This is
Jiabao-Sun commented on PR #23411:
URL: https://github.com/apache/flink/pull/23411#issuecomment-1754523455
Hi @wuchong, could you help review this when you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
43 matches
Mail list logo
