Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: Configuration [flink]

2024-04-15 Thread via GitHub
Jiabao-Sun merged PR #24612: URL: https://github.com/apache/flink/pull/24612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: Configuration [flink]

2024-04-15 Thread via GitHub
GOODBOY008 commented on code in PR #24612: URL: https://github.com/apache/flink/pull/24612#discussion_r1565637869 ## flink-core/src/test/java/org/apache/flink/configuration/ReadableWritableConfigurationTest.java: ## @@ -169,7 +170,7 @@ void testGetOptionalFromObject() {

Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: Configuration [flink]

2024-04-15 Thread via GitHub
GOODBOY008 commented on code in PR #24612: URL: https://github.com/apache/flink/pull/24612#discussion_r1565642234 ## flink-core/src/test/java/org/apache/flink/configuration/GlobalConfigurationTest.java: ## @@ -42,57 +42,48 @@ class GlobalConfigurationTest { @TempDir

Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: Configuration [flink]

2024-04-15 Thread via GitHub
GOODBOY008 commented on code in PR #24612: URL: https://github.com/apache/flink/pull/24612#discussion_r1565637869 ## flink-core/src/test/java/org/apache/flink/configuration/ReadableWritableConfigurationTest.java: ## @@ -169,7 +170,7 @@ void testGetOptionalFromObject() {

Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: Configuration [flink]

2024-04-15 Thread via GitHub
Jiabao-Sun commented on code in PR #24612: URL: https://github.com/apache/flink/pull/24612#discussion_r1565548513 ## flink-core/src/test/java/org/apache/flink/configuration/MemorySizePrettyPrintingTest.java: ## @@ -45,13 +46,13 @@ public static Object[][] parameters() {

Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: Configuration [flink]

2024-04-14 Thread via GitHub
Jiabao-Sun commented on code in PR #24612: URL: https://github.com/apache/flink/pull/24612#discussion_r1565204190 ## flink-core/src/test/java/org/apache/flink/configuration/ConfigurationConversionsTest.java: ## @@ -52,7 +51,9 @@ public class ConfigurationConversionsTest {

Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: Configuration [flink]

2024-04-14 Thread via GitHub
1996fanrui commented on code in PR #24612: URL: https://github.com/apache/flink/pull/24612#discussion_r1565149231 ## flink-core/src/test/java/org/apache/flink/configuration/FilesystemSchemeConfigTest.java: ## @@ -21,83 +21,79 @@ import org.apache.flink.core.fs.FileSystem;

Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: Configuration [flink]

2024-04-08 Thread via GitHub
GOODBOY008 commented on PR #24612: URL: https://github.com/apache/flink/pull/24612#issuecomment-2044061547 @Jiabao-Sun @1996fanrui PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: Configuration [flink]

2024-04-04 Thread via GitHub
flinkbot commented on PR #24612: URL: https://github.com/apache/flink/pull/24612#issuecomment-2036688897 ## CI report: * 94ff81023ed7f0fe9e9a2afd45ba73bd0006c134 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: Configuration [flink]

2024-04-03 Thread via GitHub
GOODBOY008 commented on PR #24612: URL: https://github.com/apache/flink/pull/24612#issuecomment-2033951840 @Jiabao-Sun PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: Configuration [flink]

2024-04-03 Thread via GitHub
GOODBOY008 opened a new pull request, #24612: URL: https://github.com/apache/flink/pull/24612 Changes: - Module: flink-core with,Package: Configuration migrate to junit5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub