Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest merged PR #24512: URL: https://github.com/apache/flink/pull/24512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest merged PR #24511: URL: https://github.com/apache/flink/pull/24511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

flinkbot commented on PR #24512: URL: https://github.com/apache/flink/pull/24512#issuecomment-2002894151 ## CI report: * 79ca29c5dd966fe4af885c9e5b18a737c5e5b6e9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest opened a new pull request, #24512: URL: https://github.com/apache/flink/pull/24512 ## What is the purpose of the change This PR is cherry-picked from https://github.com/apache/flink/pull/24390 ## Brief change log - Fix unstable

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

flinkbot commented on PR #24511: URL: https://github.com/apache/flink/pull/24511#issuecomment-2002875245 ## CI report: * 09a83bf383c13f3262a61279871cc0e9882f6e47 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest opened a new pull request, #24511: URL: https://github.com/apache/flink/pull/24511 ## What is the purpose of the change This PR is cherry-picked from https://github.com/apache/flink/pull/24390 ## Brief change log - Fix unstable

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24492: URL: https://github.com/apache/flink/pull/24492#discussion_r1524697588 ## flink-architecture-tests/flink-architecture-tests-production/archunit-violations/f7a4e6fa-e7de-48c9-a61e-c13e83f0c72e: ## @@ -679,17 +679,18 @@ Method calls

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24492: URL: https://github.com/apache/flink/pull/24492#discussion_r1524719948 ## flink-architecture-tests/flink-architecture-tests-production/archunit-violations/f7a4e6fa-e7de-48c9-a61e-c13e83f0c72e: ## @@ -679,17 +679,18 @@ Method calls

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest merged PR #24492: URL: https://github.com/apache/flink/pull/24492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24492: URL: https://github.com/apache/flink/pull/24492#discussion_r1524698054 ## flink-architecture-tests/flink-architecture-tests-production/archunit-violations/f7a4e6fa-e7de-48c9-a61e-c13e83f0c72e: ## @@ -679,17 +679,18 @@ Method calls

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24492: URL: https://github.com/apache/flink/pull/24492#discussion_r1524697588 ## flink-architecture-tests/flink-architecture-tests-production/archunit-violations/f7a4e6fa-e7de-48c9-a61e-c13e83f0c72e: ## @@ -679,17 +679,18 @@ Method calls

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24492: URL: https://github.com/apache/flink/pull/24492#discussion_r1524695213 ## flink-architecture-tests/flink-architecture-tests-production/archunit-violations/f7a4e6fa-e7de-48c9-a61e-c13e83f0c72e: ## @@ -679,17 +679,18 @@ Method calls

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24492: URL: https://github.com/apache/flink/pull/24492#discussion_r1524607876 ## flink-architecture-tests/flink-architecture-tests-production/archunit-violations/f7a4e6fa-e7de-48c9-a61e-c13e83f0c72e: ## @@ -679,17 +679,18 @@ Method calls method

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on PR #24492: URL: https://github.com/apache/flink/pull/24492#issuecomment-1997117461 > LGTM  But this fix could even go into 1.18 and 1.17, doesn't it? Yes, indeed. I'll create another two PRs shortly. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

flinkbot commented on PR #24492: URL: https://github.com/apache/flink/pull/24492#issuecomment-1996302414 ## CI report: * 63db84c3fb1d069c48e0efe8733e63d4dd912777 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest opened a new pull request, #24492: URL: https://github.com/apache/flink/pull/24492 ## What is the purpose of the change This PR is cherry-picked from #24390 ## Brief change log * Fix unstable TableSourceITCase#testTableHintWithLogicalTableScanReuse *

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest merged PR #24390: URL: https://github.com/apache/flink/pull/24390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on PR #24390: URL: https://github.com/apache/flink/pull/24390#issuecomment-1993735441 No, go ahead. It would be good to provide backports as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on PR #24390: URL: https://github.com/apache/flink/pull/24390#issuecomment-1993628470 Hi @XComp, I plan to merge PR since the CI passed unless you have any other concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on PR #24390: URL: https://github.com/apache/flink/pull/24390#issuecomment-1991461563 Hi [XComp](https://github.com/XComp), thanks so much for the time and effort you've put into the review and discussion :) -- This is an automated message from the Apache Git

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521248255 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -282,7 +278,7 @@ private

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521195360 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -37,24 +39,44 @@ import

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521155291 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemOutputFormat.java: ## @@ -96,6 +99,22 @@ private

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521155291 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemOutputFormat.java: ## @@ -96,6 +99,22 @@ private

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521128496 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -70,6 +85,11 @@ private static

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521036729 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -83,157 +110,193 @@ void after() {

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1507274806 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -104,15 +113,101 @@ void

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1520768668 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemOutputFormat.java: ## @@ -286,10 +302,21 @@ public Builder

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1520757091 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -70,6 +85,11 @@ private static

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1520696809 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -83,153 +103,175 @@ void

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1520688625 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemOutputFormat.java: ## @@ -197,13 +200,37 @@ public void

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1519417563 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -83,153 +103,175 @@ void after() {

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1512605257 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/utils/PathUtils.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1512374782 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/utils/PathUtils.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1512103738 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/utils/PathUtils.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1512083846 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/utils/PathUtilsTest.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1512043134 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/utils/PathUtils.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1511414346 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/utils/PathUtils.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on PR #24390: URL: https://github.com/apache/flink/pull/24390#issuecomment-1976845985 Hi @XComp, would you mind taking a look when you're available? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1508526295 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/utils/PathUtils.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1507274806 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -104,15 +113,101 @@ void

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1507288792 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -104,15 +113,101 @@ void

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on PR #24390: URL: https://github.com/apache/flink/pull/24390#issuecomment-1970712539 Actually, after looking at the code for `HiveTableSink`

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on PR #24390: URL: https://github.com/apache/flink/pull/24390#issuecomment-1970685919 What do you think if we move `toStagingPath` to `FileSystemOutputFormat`? Sth. like ```java private FileSystemOutputFormat( FileSystemFactory fsFactory,

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1507204553 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSink.java: ## @@ -386,6 +389,11 @@ private Path

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1507195791 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -104,15 +113,101 @@ void

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1507187446 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -104,15 +113,101 @@ void

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1507172607 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSink.java: ## @@ -374,7 +375,9 @@ public

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1507150180 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSink.java: ## @@ -386,6 +389,11 @@ private Path

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on PR #24390: URL: https://github.com/apache/flink/pull/24390#issuecomment-1970441742 Hi @snuyanzin @XComp, thanks for your comments on the review. I updated the test (actually not perfect either..) and tried best to verify the case. Would you mind retaking a look?

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505976015 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## Review Comment: Thanks for

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505887655 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSink.java: ## @@ -374,7 +374,10 @@ public

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505879003 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## Review Comment: How can we

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505871123 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## Review Comment: > As said,

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505864009 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## Review Comment: > > [...] the

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505838606 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## Review Comment: Personally, I

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505832996 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## Review Comment: > [...] the issue

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505822872 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## Review Comment: The reason I

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505818193 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSink.java: ## @@ -374,7 +374,10 @@ public

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505814697 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSink.java: ## @@ -374,7 +374,10 @@ public

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505814186 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSink.java: ## @@ -374,7 +374,10 @@ public

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

snuyanzin commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505790506 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## Review Comment: yes, confirm,

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505770714 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## Review Comment: I guess, I'm not

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

snuyanzin commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505763661 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -104,15 +110,139 @@ void