Re: [PR] [FLINK-30687][table] Support pushdown for aggregate filters [flink]

2024-05-24 Thread via GitHub
jeyhunkarimov commented on PR #24660: URL: https://github.com/apache/flink/pull/24660#issuecomment-2130159573 Hi @JingGe , I added support for multiple aggregates with the same filter (to push down their filters). Could you please check the PR in your available time? Thanks! -- This is

Re: [PR] [FLINK-30687][table] Support pushdown for aggregate filters [flink]

2024-05-22 Thread via GitHub
jeyhunkarimov commented on code in PR #24660: URL: https://github.com/apache/flink/pull/24660#discussion_r1609526426 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/AggregateFilterPushdownRule.java: ## @@ -0,0 +1,112 @@ +/* + *

Re: [PR] [FLINK-30687][table] Support pushdown for aggregate filters [flink]

2024-05-21 Thread via GitHub
JingGe commented on code in PR #24660: URL: https://github.com/apache/flink/pull/24660#discussion_r1607944798 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/AggregateFilterPushdownRule.java: ## @@ -0,0 +1,112 @@ +/* + *

Re: [PR] [FLINK-30687][table] Support pushdown for aggregate filters [flink]

2024-05-21 Thread via GitHub
JingGe commented on code in PR #24660: URL: https://github.com/apache/flink/pull/24660#discussion_r1607944798 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/AggregateFilterPushdownRule.java: ## @@ -0,0 +1,112 @@ +/* + *

Re: [PR] [FLINK-30687][table] Support pushdown for aggregate filters [flink]

2024-05-21 Thread via GitHub
JingGe commented on code in PR #24660: URL: https://github.com/apache/flink/pull/24660#discussion_r1607945420 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/AggregateFilterPushdownRule.java: ## @@ -0,0 +1,112 @@ +/* + *

Re: [PR] [FLINK-30687][table] Support pushdown for aggregate filters [flink]

2024-04-14 Thread via GitHub
flinkbot commented on PR #24660: URL: https://github.com/apache/flink/pull/24660#issuecomment-2054018936 ## CI report: * e5e78f553679c92f336b4f4fdccb31b95dd7bad9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-30687][table] Support pushdown for aggregate filters [flink]

2024-04-14 Thread via GitHub
jeyhunkarimov opened a new pull request, #24660: URL: https://github.com/apache/flink/pull/24660 ## What is the purpose of the change This PR supports pushing down filters for aggregate expressions. Not that this optimization works if there is single aggregate expression with