Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-05-07 Thread via GitHub
Zakelly closed pull request #24640: [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager URL: https://github.com/apache/flink/pull/24640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-30 Thread via GitHub
ljz2051 commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1584382431 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -575,8 +576,51 @@ private void createManagedDi

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-30 Thread via GitHub
ljz2051 commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1584375937 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -575,8 +576,51 @@ private void createManagedDi

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-30 Thread via GitHub
ljz2051 commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1584364578 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java: ## @@ -830,6 +832,8 @@ public CompletableFuture submitTask(

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-30 Thread via GitHub
ljz2051 commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1584361582 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -575,8 +576,51 @@ private void createManagedDi

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-28 Thread via GitHub
fredia commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1582077221 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -575,8 +576,51 @@ private void createManagedDir

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-25 Thread via GitHub
ljz2051 commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1579435004 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -575,8 +576,51 @@ private void createManagedDi

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-25 Thread via GitHub
ljz2051 commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1579435004 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -575,8 +576,51 @@ private void createManagedDi

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-22 Thread via GitHub
Zakelly commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1574334314 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java: ## @@ -830,6 +832,8 @@ public CompletableFuture submitTask(

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-12 Thread via GitHub
ljz2051 commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1562174418 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -547,4 +548,43 @@ private void createManagedDi

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-11 Thread via GitHub
Zakelly commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1560731003 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -547,4 +548,43 @@ private void createManagedDi

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-09 Thread via GitHub
fredia commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1557536559 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -547,4 +548,43 @@ private void createManagedDir

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-09 Thread via GitHub
ljz2051 commented on PR #24640: URL: https://github.com/apache/flink/pull/24640#issuecomment-2044605255 @Zakelly @fredia @masteryhx Could you please take a look ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-09 Thread via GitHub
flinkbot commented on PR #24640: URL: https://github.com/apache/flink/pull/24640#issuecomment-2044601959 ## CI report: * 475bd17770242252ed449148afe8d4021f833176 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-09 Thread via GitHub
ljz2051 opened a new pull request, #24640: URL: https://github.com/apache/flink/pull/24640 ## What is the purpose of the change This pull request introduces the restoration mechanism for FileMergingSnapshotManager. See FLIP-306 for more information. ## Brief change log