Samrat002 commented on PR #114:
URL:
https://github.com/apache/flink-connector-aws/pull/114#issuecomment-2094737962
> I have left some comments, I will continue the review later. I believe
this PR is incomplete right? we still need to add tests.
yes , tests were not added , since it
Samrat002 commented on code in PR #114:
URL:
https://github.com/apache/flink-connector-aws/pull/114#discussion_r1590270090
##
flink-connector-aws/flink-connector-redshift/src/main/java/org/apache/flink/connector/redshift/table/RedshiftDynamicTableFactory.java:
##
@@ -0,0
Samrat002 commented on code in PR #114:
URL:
https://github.com/apache/flink-connector-aws/pull/114#discussion_r1590269554
##
flink-connector-aws/flink-connector-redshift/src/main/java/org/apache/flink/connector/redshift/table/RedshiftDynamicTableFactory.java:
##
@@ -0,0
vahmed-hamdy commented on code in PR #114:
URL:
https://github.com/apache/flink-connector-aws/pull/114#discussion_r1519868784
##
flink-connector-aws/flink-connector-redshift/src/main/java/org/apache/flink/connector/redshift/table/RedshiftDynamicTableFactory.java:
##
@@ -0,0
Samrat002 commented on PR #114:
URL:
https://github.com/apache/flink-connector-aws/pull/114#issuecomment-1916403746
> 1、The tuncate table paramter is supported in the batch import scenario. If
data exists in a table, duplicate data will be generated and the table must be
cleared first
melin commented on PR #114:
URL:
https://github.com/apache/flink-connector-aws/pull/114#issuecomment-1901773568
1、The tuncate table paramter is supported in the batch import scenario. If
data exists in a table, duplicate data will be generated and the table must be
cleared first
2、Can
Samrat002 commented on PR #114:
URL:
https://github.com/apache/flink-connector-aws/pull/114#issuecomment-1866305970
@hlteoh37, @vahmed-hamdy please review in free time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
