Re: [PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

2024-02-20 Thread via GitHub
twalthr closed pull request #24121: [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize URL: https://github.com/apache/flink/pull/24121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

2024-02-19 Thread via GitHub
lincoln-lil commented on PR #24121: URL: https://github.com/apache/flink/pull/24121#issuecomment-1953417819 @twalthr Thank you for reviewing this! Yes, some work was needed to make it more readable, the original scala version use the same case branch style as

Re: [PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

2024-02-19 Thread via GitHub
twalthr commented on PR #24121: URL: https://github.com/apache/flink/pull/24121#issuecomment-1952690603 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

2024-01-17 Thread via GitHub
lincoln-lil commented on PR #24121: URL: https://github.com/apache/flink/pull/24121#issuecomment-1897800621 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

2024-01-17 Thread via GitHub
flinkbot commented on PR #24121: URL: https://github.com/apache/flink/pull/24121#issuecomment-1896046753 ## CI report: * 7ac2146e6a24322d63847904e67c16d08c9c4db8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

2024-01-17 Thread via GitHub
lincoln-lil opened a new pull request, #24121: URL: https://github.com/apache/flink/pull/24121 ## What is the purpose of the change As discussed in the jira of FLINK-33182, metadata columns will not affect determinism when ChangelogNormalize is enabled, this pr aims to relax ndu-anlayze