Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2024-01-02 Thread via GitHub
Myasuka closed pull request #23820: [FLINK-33433][rest] Introduce async-profiler to support profiling Job… URL: https://github.com/apache/flink/pull/23820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2024-01-01 Thread via GitHub
yuchen-ecnu commented on code in PR #23820: URL: https://github.com/apache/flink/pull/23820#discussion_r1439004722 ## flink-runtime/src/test/java/org/apache/flink/runtime/util/profiler/ProfilingServiceTest.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2024-01-01 Thread via GitHub
yuchen-ecnu commented on PR #23820: URL: https://github.com/apache/flink/pull/23820#issuecomment-1873273628 > I think a better understanding of how to write unit tests is important, you can refer to other existing tests. Please take a look at my comments. Hi @Myasuka , Sorry for

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2023-12-17 Thread via GitHub
Myasuka commented on code in PR #23820: URL: https://github.com/apache/flink/pull/23820#discussion_r1429195464 ## flink-runtime/src/test/java/org/apache/flink/runtime/util/profiler/ProfilingServiceTest.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2023-12-17 Thread via GitHub
Myasuka commented on code in PR #23820: URL: https://github.com/apache/flink/pull/23820#discussion_r1429195243 ## flink-runtime/src/test/java/org/apache/flink/runtime/util/profiler/ProfilingServiceTest.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2023-12-16 Thread via GitHub
yuchen-ecnu commented on code in PR #23820: URL: https://github.com/apache/flink/pull/23820#discussion_r1428757740 ## flink-runtime/src/test/java/org/apache/flink/runtime/util/profiler/ProfilingServiceTest.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2023-12-16 Thread via GitHub
yuchen-ecnu commented on code in PR #23820: URL: https://github.com/apache/flink/pull/23820#discussion_r1428757670 ## flink-runtime/src/test/java/org/apache/flink/runtime/util/profiler/ProfilingServiceTest.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2023-12-12 Thread via GitHub
Myasuka commented on code in PR #23820: URL: https://github.com/apache/flink/pull/23820#discussion_r1423532806 ## flink-runtime/src/test/java/org/apache/flink/runtime/util/profiler/ProfilingServiceTest.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2023-12-06 Thread via GitHub
yuchen-ecnu commented on code in PR #23820: URL: https://github.com/apache/flink/pull/23820#discussion_r1416993727 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/ProfilingService.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2023-12-01 Thread via GitHub
Myasuka commented on code in PR #23820: URL: https://github.com/apache/flink/pull/23820#discussion_r1412050762 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/ProfilingService.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2023-12-01 Thread via GitHub
yuchen-ecnu commented on code in PR #23820: URL: https://github.com/apache/flink/pull/23820#discussion_r1411956350 ## flink-runtime-web/web-dashboard/src/app/pages/job-manager/profiler/job-manager-profiler.component.html: ## @@ -0,0 +1,108 @@ + + + + + + +

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2023-11-30 Thread via GitHub
Myasuka commented on code in PR #23820: URL: https://github.com/apache/flink/pull/23820#discussion_r1411573550 ## flink-runtime-web/web-dashboard/src/app/pages/job-manager/profiler/job-manager-profiler.component.html: ## @@ -0,0 +1,108 @@ + + + + + + +

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2023-11-28 Thread via GitHub
flinkbot commented on PR #23820: URL: https://github.com/apache/flink/pull/23820#issuecomment-1830313536 ## CI report: * 48b2e2941d84938b7fecc74df5b110fe853835c4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2023-11-28 Thread via GitHub
yuchen-ecnu opened a new pull request, #23820: URL: https://github.com/apache/flink/pull/23820 …Manager via REST API ## What is the purpose of the change This is a subtask of [FLIP-375](https://cwiki.apache.org/confluence/x/64lEE), which introduces the async-profiler for