MartijnVisser merged PR #32:
URL: https://github.com/apache/flink-connector-hbase/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ferenc-csaky commented on code in PR #32:
URL:
https://github.com/apache/flink-connector-hbase/pull/32#discussion_r1396065742
##
flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java:
##
@@ -66,16 +66,13 @@
import static
ferenc-csaky commented on code in PR #32:
URL:
https://github.com/apache/flink-connector-hbase/pull/32#discussion_r1396049215
##
flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java:
##
Review Comment:
Yep, good catch, I
Tan-JiaLiang commented on code in PR #32:
URL:
https://github.com/apache/flink-connector-hbase/pull/32#discussion_r1395316627
##
flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java:
##
Review Comment:
I think we should drop
ferenc-csaky commented on PR #32:
URL:
https://github.com/apache/flink-connector-hbase/pull/32#issuecomment-1812031612
@Tan-JiaLiang if you have some time, can you take a look pls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ferenc-csaky opened a new pull request, #32:
URL: https://github.com/apache/flink-connector-hbase/pull/32
Update the existing tests to JUnit5.
Except `HBaseTablePlanTest`, which is based on `TableTestBase` from the core
Flink repo, that is still on JUnit4.
--
This is an automated
