libenchao closed pull request #23937: [FLINK-33611] [flink-protobuf] Support
Large Protobuf Schemas
URL: https://github.com/apache/flink/pull/23937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sharath1709 commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1915503745
@libenchao Gentle ping on the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sharath1709 commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1885748350
@libenchao Could you review this PR again, it is updated as per our
discussion on the JIRA ticket and I also added a test case that fails without
the changes in this PR.
--
This
sharath1709 commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1883804593
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sharath1709 commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1882015968
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sharath1709 commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1881909991
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sharath1709 commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1879310386
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
libenchao commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1873903277
@sharath1709 sorry for the delay, I haven't checked the code/design yet, but
can you add a test case that fails without this improvement?
--
This is an automated message from the
sharath1709 commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1866817077
@libenchao Thanks for the quick response. Sure, let's try to reach an
agreement on the JIRA first
--
This is an automated message from the Apache Git Service.
To respond to the
libenchao commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1866145686
@sharath1709 Thanks for your contribution. Per the community's convention,
we need to reach an agreement on the issue before we go to the PR review. I'll
comment on the corresponding
sharath1709 commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1865255265
@libenchao Can you please review this PR? I see you're one of the main
reviewer for this module in the past
--
This is an automated message from the Apache Git Service.
To respond
sharath1709 commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1863633658
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sharath1709 commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1863449372
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sharath1709 commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1858595168
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
flinkbot commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1858559404
## CI report:
* e474d8114a2328c5d529d8e1084d685906ee502e UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
sharath1709 opened a new pull request, #23937:
URL: https://github.com/apache/flink/pull/23937
## What is the purpose of the change
This change is made to support large Protobuf schemas
## Brief change log
- [FLINK-33611] [flink-protobuf] Reuse
16 matches
Mail list logo
