gyfora merged PR #733:
URL: https://github.com/apache/flink-kubernetes-operator/pull/733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
AncyRominus commented on PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#issuecomment-1891799251
Thank you @gyfora ! I have incorporated the review comments. Please re-review
--
This is an automated message from the Apache Git Service.
To respond to the
gyfora commented on code in PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#discussion_r1452023246
##
flink-kubernetes-webhook/src/main/java/org/apache/flink/kubernetes/operator/admission/mutator/FlinkMutator.java:
##
@@ -17,55 +17,82 @@
package
gyfora commented on code in PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#discussion_r1444204137
##
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/MutatorUtils.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the
AncyRominus commented on code in PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#discussion_r1440100481
##
flink-kubernetes-webhook/src/main/java/org/apache/flink/kubernetes/operator/admission/mutator/FlinkMutator.java:
##
@@ -17,43 +17,88 @@
AncyRominus commented on code in PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#discussion_r1440100481
##
flink-kubernetes-webhook/src/main/java/org/apache/flink/kubernetes/operator/admission/mutator/FlinkMutator.java:
##
@@ -17,43 +17,88 @@
gyfora commented on code in PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#discussion_r1435156526
##
flink-kubernetes-webhook/src/main/java/org/apache/flink/kubernetes/operator/admission/mutator/FlinkMutator.java:
##
@@ -17,43 +17,88 @@
package
gyfora commented on code in PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#discussion_r1435156017
##
flink-kubernetes-webhook/src/main/java/org/apache/flink/kubernetes/operator/admission/mutator/FlinkMutator.java:
##
@@ -17,43 +17,88 @@
package
tagarr commented on PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#issuecomment-1864167599
@gyfora We had considered adding mutation into the controller loop in the
same manner that the validator is done, but we believe that mutation of the CR
should only
AncyRominus commented on PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#issuecomment-1859901718
Thanks for the comments @tagarr and @gyfora !!!
The modify labels are set in FlinkMutator.java and the other mutator changes
(if any) be added to the default or
AncyRominus commented on code in PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#discussion_r1429772463
##
flink-kubernetes-operator/pom.xml:
##
@@ -208,6 +208,18 @@ under the License.
junit-jupiter-params
test
+
+
AncyRominus commented on code in PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#discussion_r1429764133
##
flink-kubernetes-webhook/pom.xml:
##
@@ -127,6 +132,11 @@ under the License.
+
gyfora commented on PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#issuecomment-1855797398
There is already a mutator implementation `FlinkMutator` I don't see that
mentioned or touched anywhere here. Could we also make sure that it is covered
by the new
gyfora commented on code in PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#discussion_r1426674867
##
flink-kubernetes-webhook/pom.xml:
##
@@ -127,6 +132,11 @@ under the License.
+
+
gyfora commented on PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#issuecomment-1855787058
```
Brief change log
No change in logs
```
This section should ideally be filled out with the list of changes that were
made to implement the given
tagarr commented on PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#issuecomment-1855604122
@gyfora would love your opinion on this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
tagarr commented on PR #733:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/733#issuecomment-1855602604
Looks good. My only question would be to the committers.
1. Would we like the sessionjob changes (i.e. modify labels) be done in
AncyRominus closed pull request #732: [FLINK-33632] Adding custom flink mutator
URL: https://github.com/apache/flink-kubernetes-operator/pull/732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AncyRominus opened a new pull request, #733:
URL: https://github.com/apache/flink-kubernetes-operator/pull/733
## What is the purpose of the change
Adding Custom Flink Mutator
## Brief change log
No change in logs
## Verifying this change
*(Please
19 matches
Mail list logo
