reswqa merged PR #39:
URL: https://github.com/apache/flink-connector-opensearch/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
boring-cyborg[bot] commented on PR #39:
URL:
https://github.com/apache/flink-connector-opensearch/pull/39#issuecomment-1996317097
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
schulzp commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-opensearch/pull/39#discussion_r1522660248
##
flink-connector-opensearch/archunit-violations/4382f1f0-807a-45ff-97d8-42f72b6e9484:
##
@@ -14,23 +14,5 @@
reswqa commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-opensearch/pull/39#discussion_r1522556968
##
flink-connector-opensearch/archunit-violations/4382f1f0-807a-45ff-97d8-42f72b6e9484:
##
@@ -14,23 +14,5 @@
reswqa commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-opensearch/pull/39#discussion_r152244
##
flink-connector-opensearch/archunit-violations/4382f1f0-807a-45ff-97d8-42f72b6e9484:
##
@@ -14,23 +14,5 @@
hajimeni commented on PR #39:
URL:
https://github.com/apache/flink-connector-opensearch/pull/39#issuecomment-1993462184
Hey, @schulzp.
I have created a PR for testing.
https://github.com/hajimeni/flink-connector-opensearch/pull/1
CI passes, so it still seems that the
schulzp commented on PR #39:
URL:
https://github.com/apache/flink-connector-opensearch/pull/39#issuecomment-1992274982
Hey @hajimeni!
> The CI error seems to be caused by differences in files under the
archunit-violations path.
> It was resolved in the following PR.
hajimeni commented on PR #39:
URL:
https://github.com/apache/flink-connector-opensearch/pull/39#issuecomment-1991441614
Hey @schulzp.
Thank you for creating this PR. It would be very helpful if this PR gets
merged.
The CI error seems to be caused by differences in files under the
schulzp commented on PR #39:
URL:
https://github.com/apache/flink-connector-opensearch/pull/39#issuecomment-1870649037
@reswqa, I checked the CI logs and it looks like `TestCodeArchitectureTest`
breaks the pipeline. It requires that "ITCASE tests should use a MiniCluster
resource or
boring-cyborg[bot] commented on PR #39:
URL:
https://github.com/apache/flink-connector-opensearch/pull/39#issuecomment-1866114172
Thanks for opening this pull request! Please check out our contributing
guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
schulzp opened a new pull request, #39:
URL: https://github.com/apache/flink-connector-opensearch/pull/39
This is a back port of the implementation for the elasticsearch connector,
see [FLINK-32028](https://issues.apache.org/jira/browse/FLINK-32028), to
achieve consistent APIs.
11 matches
Mail list logo
