Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-27 Thread via GitHub
hackergin commented on PR #24290: URL: https://github.com/apache/flink/pull/24290#issuecomment-196804 @xuyangzhong Thank you for the valuable suggestion. Following your advice, I have added relevant unit tests. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-26 Thread via GitHub
xuyangzhong commented on code in PR #24290: URL: https://github.com/apache/flink/pull/24290#discussion_r1503596812 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala: ## @@ -220,6 +225,63 @@ class Grou

Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-25 Thread via GitHub
hackergin commented on PR #24290: URL: https://github.com/apache/flink/pull/24290#issuecomment-1963175680 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-25 Thread via GitHub
hackergin commented on PR #24290: URL: https://github.com/apache/flink/pull/24290#issuecomment-1963171195 @xuyangzhong @fsk119 Please help review when you have time, thank you. @jeyhunkarimov Do you have any other suggestions for this PR? -- This is an automated message from the

Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-13 Thread via GitHub
hackergin commented on code in PR #24290: URL: https://github.com/apache/flink/pull/24290#discussion_r1488851119 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala: ## @@ -220,6 +225,63 @@ class GroupA

Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-10 Thread via GitHub
jeyhunkarimov commented on code in PR #24290: URL: https://github.com/apache/flink/pull/24290#discussion_r1485282227 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/MiniBatchGlobalGroupAggFunction.java: ## @@ -193,7 +193,7 @@ p

Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-10 Thread via GitHub
jeyhunkarimov commented on code in PR #24290: URL: https://github.com/apache/flink/pull/24290#discussion_r1485270891 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala: ## @@ -220,6 +225,63 @@ class Gr

Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-09 Thread via GitHub
hackergin commented on PR #24290: URL: https://github.com/apache/flink/pull/24290#issuecomment-1936224206 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-07 Thread via GitHub
flinkbot commented on PR #24290: URL: https://github.com/apache/flink/pull/24290#issuecomment-1933490545 ## CI report: * 096179ded432aefd53274cc26402c82a274b4865 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-07 Thread via GitHub
hackergin opened a new pull request, #24290: URL: https://github.com/apache/flink/pull/24290 ## What is the purpose of the change *Outputting Identical Results in Mini-Batch Aggregation with Set TTL* ## Brief change log - Outputting Identical Results in Mini-Batch A