Re: [PR] [FLINK-34134] Add tracing for restored state size and locations [flink]

2024-01-18 Thread via GitHub
StefanRRichter merged PR #24119: URL: https://github.com/apache/flink/pull/24119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34134] Add tracing for restored state size and locations [flink]

2024-01-18 Thread via GitHub
StefanRRichter closed pull request #24119: [FLINK-34134] Add tracing for restored state size and locations URL: https://github.com/apache/flink/pull/24119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-34134] Add tracing for restored state size and locations [flink]

2024-01-18 Thread via GitHub
StefanRRichter commented on code in PR #24119: URL: https://github.com/apache/flink/pull/24119#discussion_r1457351231 ## docs/content.zh/docs/ops/traces.md: ## @@ -159,6 +159,14 @@ Flink reports a single span trace for the whole checkpoint and job initializatio

Re: [PR] [FLINK-34134] Add tracing for restored state size and locations [flink]

2024-01-18 Thread via GitHub
StefanRRichter commented on code in PR #24119: URL: https://github.com/apache/flink/pull/24119#discussion_r1457349158 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/StateHandleDownloadSpec.java: ## @@ -53,7 +53,9 @@

Re: [PR] [FLINK-34134] Add tracing for restored state size and locations [flink]

2024-01-18 Thread via GitHub
StefanRRichter commented on code in PR #24119: URL: https://github.com/apache/flink/pull/24119#discussion_r1457346844 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamTaskStateInitializerImpl.java: ## @@ -227,6 +238,24 @@ public

Re: [PR] [FLINK-34134] Add tracing for restored state size and locations [flink]

2024-01-18 Thread via GitHub
StefanRRichter commented on code in PR #24119: URL: https://github.com/apache/flink/pull/24119#discussion_r1457345256 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/StateObject.java: ## @@ -63,4 +64,60 @@ public interface StateObject extends Serializable {

Re: [PR] [FLINK-34134] Add tracing for restored state size and locations [flink]

2024-01-18 Thread via GitHub
pnowojski commented on code in PR #24119: URL: https://github.com/apache/flink/pull/24119#discussion_r1457322520 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/StateHandleDownloadSpec.java: ## @@ -53,7 +53,9 @@ public

Re: [PR] [FLINK-34134] Add tracing for restored state size and locations [flink]

2024-01-17 Thread via GitHub
flinkbot commented on PR #24119: URL: https://github.com/apache/flink/pull/24119#issuecomment-1895884723 ## CI report: * 5752457fc6142577ba63e376e11f15e0dfeb5dfc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34134] Add tracing for restored state size and locations [flink]

2024-01-17 Thread via GitHub
StefanRRichter opened a new pull request, #24119: URL: https://github.com/apache/flink/pull/24119 ## What is the purpose of the change Introduces tracing for state sizes and locations in task recovery. This is particularly interesting for a mixed recovery with some local and some