liuyongvs commented on PR #24373:
URL: https://github.com/apache/flink/pull/24373#issuecomment-2111617766
hi @snuyanzin will you help review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
liuyongvs commented on PR #24373:
URL: https://github.com/apache/flink/pull/24373#issuecomment-2043128185
hi @snuyanzin will you also help review this pr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
liuyongvs commented on code in PR #24373:
URL: https://github.com/apache/flink/pull/24373#discussion_r1500411569
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinDeriveNullFilterRule.java:
##
@@ -59,7 +59,7 @@ public class
liuyongvs commented on PR #24373:
URL: https://github.com/apache/flink/pull/24373#issuecomment-1987508136
hi @snuyanzin will you also help review this pr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
liuyongvs commented on PR #24373:
URL: https://github.com/apache/flink/pull/24373#issuecomment-1980642419
hi @dawidwys will you also help review this pr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
liuyongvs commented on code in PR #24373:
URL: https://github.com/apache/flink/pull/24373#discussion_r1500411569
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinDeriveNullFilterRule.java:
##
@@ -59,7 +59,7 @@ public class
flinkbot commented on PR #24373:
URL: https://github.com/apache/flink/pull/24373#issuecomment-1960739934
## CI report:
* 66a51ec643ce5844fb05cb76fce2e390e8ac12d1 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
liuyongvs opened a new pull request, #24373:
URL: https://github.com/apache/flink/pull/24373
## What is the purpose of the change
The PR migrates JoinDeriveNullFilterRule to java
it doesn't touch JoinDeriveNullFilterRuleTest to be sure that java version
continues passing it
