1996fanrui merged PR #785:
URL: https://github.com/apache/flink-kubernetes-operator/pull/785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1996fanrui commented on PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#issuecomment-2114192076
> Thanks @czy006 for the contribution and @1996fanrui for the review. LGTM
on the whole. Just left a few of minor comments. PATL if you had the free time.
:)
RocMarshal commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1602676542
##
flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/utils/HikariJDBCUtil.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed
RocMarshal commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1602673972
##
flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/utils/HikariJDBCUtil.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed
1996fanrui commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1599663405
##
flink-autoscaler-standalone/pom.xml:
##
@@ -133,6 +133,12 @@ under the License.
${log4j.version}
+
+
1996fanrui commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1538587604
##
flink-autoscaler/pom.xml:
##
@@ -57,6 +57,18 @@ under the License.
org.quartz-scheduler
quartz
czy006 commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1538521734
##
flink-autoscaler-standalone/pom.xml:
##
@@ -133,6 +133,12 @@ under the License.
${log4j.version}
+
+
czy006 commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1538520848
##
flink-autoscaler/pom.xml:
##
@@ -57,6 +57,18 @@ under the License.
org.quartz-scheduler
quartz
1996fanrui commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1538509399
##
flink-autoscaler/pom.xml:
##
@@ -57,6 +57,18 @@ under the License.
org.quartz-scheduler
quartz
1996fanrui commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1537108398
##
flink-autoscaler-standalone/pom.xml:
##
@@ -163,6 +163,12 @@ under the License.
test
+
Review Comment:
It's
1996fanrui commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1535117714
##
flink-autoscaler-standalone/src/test/java/org/apache/flink/autoscaler/standalone/AutoscalerStateStoreFactoryTest.java:
##
@@ -64,19 +63,20 @@
czy006 commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1533316957
##
flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/utils/HikariJDBCUtil.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to
czy006 commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1533316345
##
flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/utils/HikariJDBCUtil.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to
1996fanrui commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1528221191
##
flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/utils/HikariJDBCUtil.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed
1996fanrui commented on code in PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#discussion_r1528175144
##
flink-autoscaler-plugin-jdbc/pom.xml:
##
@@ -140,6 +140,12 @@ under the License.
test
+
+com.zaxxer
czy006 commented on PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#issuecomment-1985477162
> Thanks @czy006 for the improvement!
>
> I'm on vacation recently, I will review it after it. Sorry for the delay.
>
> Btw, `1.8.0` will be released soon,
czy006 commented on PR #785:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/785#issuecomment-1982887388
@1996fanrui PLAT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
czy006 opened a new pull request, #785:
URL: https://github.com/apache/flink-kubernetes-operator/pull/785
## What is the purpose of the change
*Autoscaler JDBC Support HikariPool to Replace JDBC DirverManager*
## Brief change log
- *Add Autoscaler
18 matches
Mail list logo
