yuxiqian closed pull request #3231: [FLINK-35092][cdc][starrocks] Add starrocks
integration test cases
URL: https://github.com/apache/flink-cdc/pull/3231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuxiqian commented on PR #3231:
URL: https://github.com/apache/flink-cdc/pull/3231#issuecomment-2152228771
Fixed in #3348.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
banmoy commented on PR #3231:
URL: https://github.com/apache/flink-cdc/pull/3231#issuecomment-2069316077
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
yuxiqian commented on PR #3231:
URL: https://github.com/apache/flink-cdc/pull/3231#issuecomment-2068610510
Thanks for @banmoy's kindly review, addressed comments above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
yuxiqian commented on code in PR #3231:
URL: https://github.com/apache/flink-cdc/pull/3231#discussion_r1574208208
##
banmoy commented on PR #3231:
URL: https://github.com/apache/flink-cdc/pull/3231#issuecomment-2068440105
@yuxiqian Thanks for the work. Left some comments. Also cc @lvyanquan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
banmoy commented on code in PR #3231:
URL: https://github.com/apache/flink-cdc/pull/3231#discussion_r1574081602
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/resources/log4j2-test.properties:
##
@@ -15,7 +15,7 @@
# Set
yuxiqian commented on PR #3231:
URL: https://github.com/apache/flink-cdc/pull/3231#issuecomment-2060583059
cc @banmoy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
yuxiqian opened a new pull request, #3231:
URL: https://github.com/apache/flink-cdc/pull/3231
This closes [FLINK-35092](https://issues.apache.org/jira/browse/FLINK-35092).
Currently, no integrated test are being applied to StarRocks pipeline
connector which runs on real docker
