Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-15 Thread via GitHub
jeyhunkarimov commented on PR #24658: URL: https://github.com/apache/flink/pull/24658#issuecomment-2057338536 Ah no worries at all, there was a misunderstanding in communication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-14 Thread via GitHub
snuyanzin commented on PR #24658: URL: https://github.com/apache/flink/pull/24658#issuecomment-2054184159 Yep, you're right probably i was not aware of the context I was judging only by timestamps I'm really sorry in case I offended in any way I would suggest in case you are

Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-13 Thread via GitHub
jeyhunkarimov commented on PR #24658: URL: https://github.com/apache/flink/pull/24658#issuecomment-2053765908 > Thanks for contribution > however it seems the test doesn't reproduce the actual issue: I tried to execute it without fix and it is green > Hi @snuyanzin thanks

Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-13 Thread via GitHub
jeyhunkarimov closed pull request #24658: [FLINK-35098][orc] Fix incorrect results in thanEquals filters URL: https://github.com/apache/flink/pull/24658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-13 Thread via GitHub
snuyanzin commented on PR #24658: URL: https://github.com/apache/flink/pull/24658#issuecomment-2053762163 Thanks for contribution however it seems the test Doesn't reproduce the actual issue: I tried to execute it without fix and it is green -- This is an automated message from

Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-13 Thread via GitHub
flinkbot commented on PR #24658: URL: https://github.com/apache/flink/pull/24658#issuecomment-2053746320 ## CI report: * bad8304a2d5ad3d9fda25596469405bc4ec9a1d4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]

2024-04-13 Thread via GitHub
jeyhunkarimov opened a new pull request, #24658: URL: https://github.com/apache/flink/pull/24658 ## What is the purpose of the change Fix incorrect results in thanEquals filters ## Brief change log - Fix the reverse function for Orc GREATER_THAN_OR_EQUAL - Fix the