Re: [PR] [FLINK-35120][doris] Add Doris integration test cases [flink-cdc]

2024-06-06 Thread via GitHub
yuxiqian closed pull request #3227: [FLINK-35120][doris] Add Doris integration test cases URL: https://github.com/apache/flink-cdc/pull/3227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-35120][doris] Add Doris integration test cases [flink-cdc]

2024-06-06 Thread via GitHub
yuxiqian commented on PR #3227: URL: https://github.com/apache/flink-cdc/pull/3227#issuecomment-2152229529 Fixed in #3348. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-35120][doris] Add Doris integration test cases [flink-cdc]

2024-04-23 Thread via GitHub
yuxiqian commented on code in PR #3227: URL: https://github.com/apache/flink-cdc/pull/3227#discussion_r1575921082 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris/src/test/java/org/apache/flink/cdc/connectors/doris/sink/utils/DorisSinkTestBase.java:

Re: [PR] [FLINK-35120][doris] Add Doris integration test cases [flink-cdc]

2024-04-22 Thread via GitHub
yuxiqian commented on PR #3227: URL: https://github.com/apache/flink-cdc/pull/3227#issuecomment-2068618701 @JNSimba Thanks for pointing it out, #3215 and #3224 share changes by extending `DorisSchemaChangeManager`. I could rebase one after merge another / combine them into one PR. @JNSimba

Re: [PR] [FLINK-35120][doris] Add Doris integration test cases [flink-cdc]

2024-04-21 Thread via GitHub
JNSimba commented on PR #3227: URL: https://github.com/apache/flink-cdc/pull/3227#issuecomment-2068453899 It seems that some codes are duplicated with pr #3222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-35120][doris] Add Doris integration test cases [flink-cdc]

2024-04-17 Thread via GitHub
leonardBang commented on PR #3227: URL: https://github.com/apache/flink-cdc/pull/3227#issuecomment-2061013529 The CI failed, could you take a look ? @yuxiqian -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-35120][doris] Add Doris integration test cases [flink-cdc]

2024-04-17 Thread via GitHub
yuxiqian commented on PR #3227: URL: https://github.com/apache/flink-cdc/pull/3227#issuecomment-2061021229 @leonardBang Seems it's `flink-cdc-pipeline-connector-values` test that keeps failing recently. Will investigate this. -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-35120][doris] Add Doris integration test cases [flink-cdc]

2024-04-16 Thread via GitHub
yuxiqian commented on PR #3227: URL: https://github.com/apache/flink-cdc/pull/3227#issuecomment-2058385113 cc @PatrickRen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [FLINK-35120][doris] Add Doris integration test cases [flink-cdc]

2024-04-16 Thread via GitHub
yuxiqian opened a new pull request, #3227: URL: https://github.com/apache/flink-cdc/pull/3227 This closes [FLINK-35120](https://issues.apache.org/jira/browse/FLINK-35120). Currently, Flink CDC Doris pipeline connector has very limited test cases (which only covers row convertion).