dawidwys merged PR #24679:
URL: https://github.com/apache/flink/pull/24679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
twalthr commented on code in PR #24679:
URL: https://github.com/apache/flink/pull/24679#discussion_r1570922395
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/MiscAggFunctionITCase.java:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the
dawidwys commented on PR #24679:
URL: https://github.com/apache/flink/pull/24679#issuecomment-2063994171
> Let's already fix some other locations with this exception:
for example:
AbstractCodeGeneratorCastRule and CastExecutor
SqlJsonUtils
Sure, any other places that you're
dawidwys commented on code in PR #24679:
URL: https://github.com/apache/flink/pull/24679#discussion_r1570850917
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInAggregateFunctionTestBase.java:
##
@@ -344,6 +361,38 @@ public void
dawidwys commented on code in PR #24679:
URL: https://github.com/apache/flink/pull/24679#discussion_r1570846758
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/MiscAggFunctionITCase.java:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the
twalthr commented on code in PR #24679:
URL: https://github.com/apache/flink/pull/24679#discussion_r1570701741
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInAggregateFunctionTestBase.java:
##
@@ -344,6 +361,38 @@ public void
flinkbot commented on PR #24679:
URL: https://github.com/apache/flink/pull/24679#issuecomment-2063755509
## CI report:
* c7d65d5679cbe4bfc52db6a2a718b8a5d2515ea3 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
dawidwys opened a new pull request, #24679:
URL: https://github.com/apache/flink/pull/24679
## What is the purpose of the change
Introduce `TableRuntimeException` to better classify intentional exceptions
thrown from SQL runtime.
## Verifying this change
Added tests
