fredia closed pull request #24698: [FLINK-35158][runtime] Error handling in
StateFuture's callback
URL: https://github.com/apache/flink/pull/24698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
fredia commented on PR #24698:
URL: https://github.com/apache/flink/pull/24698#issuecomment-2099597032
Thanks for the detailed review, rebased to master. Will merge after CI
green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
yunfengzhou-hub commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1592131320
##
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncStateException.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1592128250
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -203,12 +251,29 @@ public void callbackFinished() {
}
@Override
-
Zakelly commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1591888669
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -203,12 +251,29 @@ public void callbackFinished() {
}
@Override
-
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1590687424
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java:
##
@@ -78,13 +81,18 @@ public
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1590680460
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -46,123 +46,169 @@ public class StateFutureImpl implements
InternalStateFuture {
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1590679773
##
flink-core/src/test/java/org/apache/flink/core/state/StateFutureTest.java:
##
@@ -37,19 +38,23 @@
/** Tests for {@link StateFuture} related implementations. */
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1590678974
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -46,123 +46,169 @@ public class StateFutureImpl implements
InternalStateFuture {
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1590672845
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -203,12 +249,29 @@ public void callbackFinished() {
}
@Override
-
Zakelly commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1590597054
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -61,23 +66,34 @@ public StateFuture thenApply(Function fn) {
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1584530942
##
flink-core-api/src/main/java/org/apache/flink/api/common/state/v2/StateFuture.java:
##
@@ -49,7 +49,7 @@ public interface StateFuture {
* @param action the
yunfengzhou-hub commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1584175343
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -46,123 +46,169 @@ public class StateFutureImpl implements
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1582504623
##
flink-core-api/src/main/java/org/apache/flink/api/common/state/v2/StateFuture.java:
##
@@ -49,7 +49,7 @@ public interface StateFuture {
* @param action the
yunfengzhou-hub commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1578908743
##
flink-core-api/src/main/java/org/apache/flink/util/function/ConsumerWithException.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1582032431
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -61,23 +66,34 @@ public StateFuture thenApply(Function fn) {
jectpro7 commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1579119199
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java:
##
@@ -58,17 +60,35 @@
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1577788928
##
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##
@@ -94,29 +109,83 @@ public class AsyncExecutionController {
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1577782892
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java:
##
@@ -58,17 +60,35 @@ public
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r159797
##
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##
@@ -94,29 +109,83 @@ public class AsyncExecutionController {
fredia commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r158129
##
flink-core/src/main/java/org/apache/flink/configuration/ExecutionOptions.java:
##
@@ -181,4 +182,62 @@ public class ExecutionOptions {
Zakelly commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1577730173
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -61,23 +66,34 @@ public StateFuture thenApply(Function fn) {
Zakelly commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1577723817
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -61,23 +66,34 @@ public StateFuture thenApply(Function fn) {
Zakelly commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1577710395
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -46,13 +46,18 @@ public class StateFutureImpl implements
InternalStateFuture {
jectpro7 commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1577181524
##
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##
@@ -94,29 +109,83 @@ public class AsyncExecutionController {
jectpro7 commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1576541718
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -46,13 +46,18 @@ public class StateFutureImpl implements
InternalStateFuture {
jectpro7 commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1576511469
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -61,23 +66,34 @@ public StateFuture thenApply(Function fn) {
jectpro7 commented on code in PR #24698:
URL: https://github.com/apache/flink/pull/24698#discussion_r1576446912
##
flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java:
##
@@ -61,23 +66,34 @@ public StateFuture thenApply(Function fn) {
flinkbot commented on PR #24698:
URL: https://github.com/apache/flink/pull/24698#issuecomment-2069754200
## CI report:
* 2b98fd70bb820730897b52e71931d182ebe2d638 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
fredia opened a new pull request, #24698:
URL: https://github.com/apache/flink/pull/24698
## What is the purpose of the change
This PR implements the error handling in StateFuture's callback, making the
job fail when any exception exception occurs in StateFuture's callback.
30 matches
Mail list logo
