Re: [PR] [FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-21 Thread via GitHub
reswqa merged PR #24688: URL: https://github.com/apache/flink/pull/24688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #24688: URL: https://github.com/apache/flink/pull/24688#discussion_r1572099075 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/SortBufferAccumulator.java: ## @@ -338,11 +365,22 @@ private

Re: [PR] [FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #24688: URL: https://github.com/apache/flink/pull/24688#discussion_r1572099075 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/SortBufferAccumulator.java: ## @@ -338,11 +365,22 @@ private

Re: [PR] [FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-19 Thread via GitHub
reswqa commented on code in PR #24688: URL: https://github.com/apache/flink/pull/24688#discussion_r1572088653 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/SortBufferAccumulator.java: ## @@ -338,11 +365,22 @@ private Buffer

Re: [PR] [FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #24688: URL: https://github.com/apache/flink/pull/24688#discussion_r1572064146 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/SortBufferAccumulator.java: ## @@ -338,11 +365,22 @@ private

Re: [PR] [FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-19 Thread via GitHub
reswqa commented on code in PR #24688: URL: https://github.com/apache/flink/pull/24688#discussion_r1572050446 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/SortBufferAccumulator.java: ## @@ -338,11 +365,22 @@ private Buffer

Re: [PR] [FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-19 Thread via GitHub
flinkbot commented on PR #24688: URL: https://github.com/apache/flink/pull/24688#issuecomment-2066126044 ## CI report: * df2d8f00cfc6feb3008df014655cc4d167c4ea62 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-19 Thread via GitHub
TanYuxin-tyx opened a new pull request, #24688: URL: https://github.com/apache/flink/pull/24688 ## What is the purpose of the change *When using sortBufferAccumulator, we should recycle the buffers to freeSegments before releasing the data buffer. The reason is that when