[PR] FLINK-30893 Replace not specifying a driver in Minikube by something … [flink]

2023-11-13 Thread via GitHub
victor09091 opened a new pull request, #23494: URL: https://github.com/apache/flink/pull/23494 ## What is the purpose of the change *we could rely on the latest minikube version and find some potential incompatible problems with new K8s versions.* ##

Re: [PR] FLINK-30893 Replace not specifying a driver in Minikube by something … [flink]

2023-11-07 Thread via GitHub
victor09091 closed pull request #23494: FLINK-30893 Replace not specifying a driver in Minikube by something … URL: https://github.com/apache/flink/pull/23494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] FLINK-30893 Replace not specifying a driver in Minikube by something … [flink]

2023-10-20 Thread via GitHub
XComp commented on code in PR #23494: URL: https://github.com/apache/flink/pull/23494#discussion_r1366757594 ## flink-end-to-end-tests/test-scripts/common_kubernetes.sh: ## @@ -54,6 +54,13 @@ function setup_kubernetes_for_linux { chmod +x minikube && sudo mv minikube

Re: [PR] FLINK-30893 Replace not specifying a driver in Minikube by something … [flink]

2023-10-20 Thread via GitHub
XComp commented on PR #23494: URL: https://github.com/apache/flink/pull/23494#issuecomment-1772428032 > Hi, Thanks @XComp for the review. I have a question, does the no driver restriction mean that the download still cannot be successful after the specified version Sorry but I'm not

Re: [PR] FLINK-30893 Replace not specifying a driver in Minikube by something … [flink]

2023-10-19 Thread via GitHub
victor9309 commented on PR #23494: URL: https://github.com/apache/flink/pull/23494#issuecomment-1772147153 Hi, Thanks @XComp for the review. I have a question, does the no driver restriction mean that the download still cannot be successful after the specified version -- This is an aut

Re: [PR] FLINK-30893 Replace not specifying a driver in Minikube by something … [flink]

2023-10-18 Thread via GitHub
XComp commented on code in PR #23494: URL: https://github.com/apache/flink/pull/23494#discussion_r1363653200 ## flink-end-to-end-tests/test-scripts/common_kubernetes.sh: ## @@ -35,23 +35,48 @@ function setup_kubernetes_for_linux { else local arch='amd64' fi +

Re: [PR] FLINK-30893 Replace not specifying a driver in Minikube by something … [flink]

2023-10-08 Thread via GitHub
flinkbot commented on PR #23494: URL: https://github.com/apache/flink/pull/23494#issuecomment-1751981530 ## CI report: * 92948c3734c75b1ab8c8c29be6cff6e63c081a45 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] FLINK-30893 Replace not specifying a driver in Minikube by something … [flink]

2023-10-08 Thread via GitHub
victor9309 opened a new pull request, #23494: URL: https://github.com/apache/flink/pull/23494 ## What is the purpose of the change *we could rely on the latest minikube version and find some potential incompatible problems with new K8s versions.* ##