[ https://issues.apache.org/jira/browse/FLINK-9665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chesnay Schepler closed FLINK-9665. ----------------------------------- Resolution: Fixed Fix Version/s: 1.5.1 1.4.3 1.6.0 master: 75d12f967ccef5df3c6c513765bb8db1106a7c87 1.5: 903a323366b91a6f2f471f067462df9dd20cd3f4 1.4: 7719fddbf570075465a7a81722f9412735e83e6e > PrometheusReporter does not properly unregister metrics > ------------------------------------------------------- > > Key: FLINK-9665 > URL: https://issues.apache.org/jira/browse/FLINK-9665 > Project: Flink > Issue Type: Bug > Components: Metrics > Affects Versions: 1.5.0, 1.4.2, 1.6.0 > Reporter: Chesnay Schepler > Assignee: Jelmer Kuperus > Priority: Major > Labels: pull-request-available > Fix For: 1.6.0, 1.4.3, 1.5.1 > > > The {{PrometheusReporter}} groups metrics with the same logical scope in a > single {{Collector}} which are periodically polled by Prometheus. > New metrics are added to an existing collector, and a reference count is > maintained so we can eventually cleanup the {{Collector}} itself. > For removed metrics we decrease the reference count, do not however remove > the metrics that were added. As a result the collector will continue to > expose metrics, as long as at least 1 metric exists with the same logical > scope. > If the collector is a {{io.prometheus.client.Gauge}} we can use the > {{#remove()}} method. For histograms we will have to modify our > {{HistogramSummaryProxy}} class to allow removing individual histograms. -- This message was sent by Atlassian JIRA (v7.6.3#76005)