[ 
https://issues.apache.org/jira/browse/FLINK-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985271#comment-16985271
 ] 

Jeff Zhang edited comment on FLINK-14991 at 2/28/20 1:43 PM:
-------------------------------------------------------------

+1, but it would be better to reserve `FLINK_CONF_DIR`. That means we could 
derive `FLINK_LIB_DIR`,`FLINK_OPT_DIR`,`FLINK_PLUGIN_DIR`,`FLINK_BIN_DIR` from 
`FLINK_HOME`, but try to look for env `FLINK_CONF_DIR` first, if it doesn't 
exist, then use `FLINK_HOME/conf`.
 The reason is that some vendor flink distribution will define `FLINK_CONF_DIR` 
separately which doesn't need to be under `FLINK_HOME`, e.g. /etc/flink/conf


was (Author: zjffdu):
+1, but it would be better to reserve `FLINK_CONF_DIR`. That means we could 
derive `FLINK_LIB_DIR`,`FLINK_OPT_DIR`,`FLINK_PLUGIN_DIR`,`FLINK_BIN_DIR` from 
`FLINK_HOME`, but try to look for env `FLINK_CONF_DIR` first, if it doesn't 
exist, then use `FLINK_HOME/conf`.
The reason is that some vendor flink distribution will define `FLINK_HOME/conf` 
separately. 

> Export `FLINK_HOME` environment variable to all the entrypoint
> --------------------------------------------------------------
>
>                 Key: FLINK-14991
>                 URL: https://issues.apache.org/jira/browse/FLINK-14991
>             Project: Flink
>          Issue Type: Improvement
>          Components: Command Line Client, Deployment / Scripts
>            Reporter: Guowei Ma
>            Priority: Minor
>
>  Currently, Flink depends on 6 types of files: configuration files, system 
> jars files, script files、library jar files, plugin jar files, and user jars 
> files. These files are in different directories. 
> Flink exports 5 environment variables to locate these different type files: 
> `FLINK_CONF_DIR`,`FLINK_LIB_DIR`,`FLINK_OPT_DIR`,`FLINK_PLUGIN_DIR`,`FLINK_BIN_DIR`.
> It is not a good style that exports an environment variable for every type of 
> file.
> So this jira proposes to export the `FLINK_HOME` environment variable to all 
> the entrypoint. Derive the directory of the different type files from the 
> `FLINK_HOME` environment variable and every type file has a fixed directory 
> name.
>  This also has another benefit that the method implies the directory 
> structure is the same in all the situations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to