[ https://issues.apache.org/jira/browse/FLINK-29610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625989#comment-17625989 ]
Jiale Tan edited comment on FLINK-29610 at 10/29/22 3:56 AM: ------------------------------------------------------------- [~gaoyunhaii] I am curious what is the difference between ASK_TIMEOUT_DURATION and [RestConfiguration.timeout|https://github.com/apache/flink/blob/5d66e82915eace9342c175163b17f610bfbf7fa4/flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java#L282] and is it ok to use the latter for the fix? was (Author: JIRAUSER290356): [~gaoyunhaii] I am curious what is the difference between ASK_TIMEOUT_DURATION and [RestConfiguration.timeout|https://github.com/apache/flink/blob/5d66e82915eace9342c175163b17f610bfbf7fa4/flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java#L282] and why it is preferred to use ASK_TIMEOUT_DURATION in this case? > Infinite timeout is used in SavepointHandlers calls to RestfulGateway > --------------------------------------------------------------------- > > Key: FLINK-29610 > URL: https://issues.apache.org/jira/browse/FLINK-29610 > Project: Flink > Issue Type: Bug > Components: Runtime / REST > Reporter: Jiale Tan > Assignee: Jiale Tan > Priority: Major > Labels: pull-request-available > > In {{{}SavepointHandlers{}}}, both > {{[StopWithSavepointHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L214]}} > and > {{[SavepointTriggerHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L258]}} > are calling {{RestfulGateway}} with {{RpcUtils.INF_TIMEOUT}} > > As pointed out in > [this|https://github.com/apache/flink/pull/20852#discussion_r992218970] > discussion, we will need to either figure out why {{RpcUtils.INF_TIMEOUT}} is > used, or remove it if there is no strong reason to use it. -- This message was sent by Atlassian Jira (v8.20.10#820010)